PBM-1484 Updated GCS configuration example and options #261
Conversation
| @@ -50,20 +50,20 @@ storage: | |||
|
|
|||
| The storage provider’s name. | |||
|
|
|||
| Supported values: `aws`, `gcs` | |||
| Supported values: `aws` | |||
There was a problem hiding this comment.
What's the purpose of that configuration if only 1 value is allowed? Should we deprecate it?
There was a problem hiding this comment.
@boris-ilijic could you please comment?
There was a problem hiding this comment.
Sorry, didn't see the message until now. Yes we removed that param from config. @veceraj can confirm
There was a problem hiding this comment.
Provider is in the s3 configuration, but even before starting my work on the AWS migration, this field had no usages. I guess we could mark it deprecated.
There was a problem hiding this comment.
marked as deprecated in the description
|
|
||
| ### storage.s3.region | ||
|
|
||
| *Type*: string <br> | ||
| *Required*: YES (for AWS and GCS) | ||
| *Required*: YES (for AWS) |
There was a problem hiding this comment.
If it's required for AWS, and AWS is the only option - it's just "YES"
There was a problem hiding this comment.
No. MinIO also uses s3 type and region is not mandatory there
modified: docs/details/storage-config-example.md modified: docs/reference/configuration-options.md
modified: docs/reference/configuration-options.md
moved related content from s3 Added HMAC options Added migration guide from s3 to gcs
nastena1606
force-pushed
the
PBM-1484-GCS-config-updates
branch
from
846ac6c to
38ee760
Compare
| @@ -50,20 +50,20 @@ storage: | |||
|
|
|||
| The storage provider’s name. | |||
|
|
|||
| Supported values: `aws`, `gcs` | |||
| Supported values: `aws` | |||
There was a problem hiding this comment.
Provider is in the s3 configuration, but even before starting my work on the AWS migration, this field had no usages. I guess we could mark it deprecated.
nastena1606
force-pushed
the
PBM-1484-GCS-config-updates
branch
from
4b59039 to
cab0f3c
Compare
modified: docs/details/storage-config-example.md
modified: docs/reference/configuration-options.md